Skip to content

[release-1.18] fix: return better error when using pack+python #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.18
Choose a base branch
from
Open

[release-1.18] fix: return better error when using pack+python #3090

wants to merge 1 commit into from

Conversation

@knative-prow-robot
Copy link

This is an automated cherry-pick of #2904

@knative-prow-robot knative-prow-robot mentioned this pull request Oct 14, 2025
Merged
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2025
@matejvasek matejvasek requested a review from dprotaso October 14, 2025 22:43
@matejvasek
Copy link
Contributor

Probably best we can do for 1.18 is better error message. Pack simple won't work with python there.

@matejvasek
Copy link
Contributor

Also many test will probably fail because the test code is not updated for the ever changing outer word.

@knative-prow
Copy link

knative-prow bot commented Oct 14, 2025

@knative-prow-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_func_release-1.18 f801c13 link true /test unit-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.66%. Comparing base (c1160e1) to head (f801c13).

Files with missing lines Patch % Lines
pkg/builders/buildpacks/builder.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.18    #3090      +/-   ##
================================================
+ Coverage         48.42%   48.66%   +0.23%     
================================================
  Files               129      131       +2     
  Lines             15787    15799      +12     
================================================
+ Hits               7645     7688      +43     
+ Misses             7455     7425      -30     
+ Partials            687      686       -1
Flag Coverage Δ
unit-tests 48.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor

gauron99 commented Oct 16, 2025 •
edited
Loading

yeah that looks reasonable to me

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@gauron99
Copy link
Contributor

/hold for @lkingland input

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@gauron99
Copy link
Contributor

gauron99 commented Nov 1, 2025

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knative-prow-robot @matejvasek @gauron99